(android) Support spend-channel-address for Taproot channels#781
Merged
(android) Support spend-channel-address for Taproot channels#781
Conversation
Code is mostly the same, although we need the remote nonce as well.
Also fixed the pay2tr missing scripts parameter.
The peer backup data may contain data for different channels, or may also miss the relevant data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spend-from-channel-address screen is a debug tool that allows users to spend funds that have been sent to a channel outpoint by mistake. This tool had been disabled with the Taproot channel update, due to the significant changes that occurred then. This PR reinstates it on the Android app.
More data are needed now. The channel id, because we use the Peer backup data to get the needed channel's data ; the remote nonce for the taproot signature.