(ios) Bug fix for inter-process communication#776
Merged
Conversation
ad7ae09 to
fc8907d
Compare
dpad85
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR:
I broken some inter-process communication stuff during the refactor for multiple-wallet support. This PR fixes the issue.
Full story:
On iOS, there are 2 separate processes:
These are 2 separate apps, with separate peer instances, which might connect and receive a payment.
In general, here's how it works:
This means that most of the time, the 2 processes are not running at the same time. But obviously, there are edge cases:
We cannot have both running at the same time, since they will interfere with each other. (Cause disconnects and/or force-closed channels.)
So to properly handle these edge cases, we use a bit of inter-process communication. The basic idea is:
This system is pretty durable, because it continues to work even if the notifySrvExt process crashes. That is, if the notifySrvExt process crashes, it will stop updating the timestamp, and it will eventually become more than 5 seconds old, allowing the mainApp to reconnect.
So what did I break: