Skip to content

(ios) Migrating to Apple-provided ViewThatFits#768

Merged
dpad85 merged 1 commit intomasterfrom
ios-view-that-fits
Oct 31, 2025
Merged

(ios) Migrating to Apple-provided ViewThatFits#768
dpad85 merged 1 commit intomasterfrom
ios-view-that-fits

Conversation

@robbiehanson
Copy link
Contributor

We have some places in the code that use an adaptive layout. For example, if it all fits on one-line, then we display it that way. Otherwise we use an alternative layout that uses 2 lines. This mostly comes into play when using larger text sizes on iOS. But translations (especially German) also occasionally trigger the alternative layouts.

In the past we used a custom solution for this. Partly based on open-source code, and partly our own creation. This kinda worked... most of the time. But it wasn't without bugs.

Now Apple has provided an official solution in the form of ViewThatFits. I've tested it, and it works much more reliably than our own custom solution. So this PR switches our adaptive code to use it instead.

@robbiehanson robbiehanson requested a review from dpad85 October 30, 2025 20:35
@dpad85 dpad85 merged commit 2a20137 into master Oct 31, 2025
@dpad85 dpad85 deleted the ios-view-that-fits branch October 31, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants