Skip to content

Update channels-db test and update electrum servers list#766

Merged
dpad85 merged 4 commits intomasterfrom
cleanup-tests
Oct 31, 2025
Merged

Update channels-db test and update electrum servers list#766
dpad85 merged 4 commits intomasterfrom
cleanup-tests

Conversation

@dpad85
Copy link
Member

@dpad85 dpad85 commented Oct 30, 2025

This PR removes the obsolete channels-db tests that were using old channels data. The new channels-db tests now work similarly to the payments-db tests, that is, try to load a version database file, and read the channels data from the base.

Note that the channels database is still in v1, it has not changed since the creation of the app. Actual channels data may have changed over the years but this is transparent to Phoenix as those data are serialised in the database, and that serialisation is tested in lightning-kmp.

This PR also updates the mainnet electrum servers list, removing some servers and adding new ones.

The test purpose is only to read the sql file in v1, not
to test the channels data serialization.
@dpad85 dpad85 requested a review from robbiehanson October 30, 2025 12:24
@robbiehanson
Copy link
Contributor

I'm seeing some errors in iosSimulatorArm64Test:

Task :phoenix-shared:iosSimulatorArm64Test
73 tests completed, 8 failed, 3 skipped

fr.acinq.phoenix.db.SqliteChannelsDbTest.read v1 db[iosSimulatorArm64] FAILED
okio.FileNotFoundException at /opt/buildAgent/work/2d153abd4d2c0600/kotlin/kotlin-native/runtime/src/main/kotlin/kotlin/Exceptions.kt:25

And also with the lintDebug:

Task :phoenix-android:lintDebug FAILED
Lint found 1 error, 440 warnings, 7 hints. First failure:

/Users/robbie/Programs/Acinq/phoenix/phoenix-android/src/main/res/values-vi/important_strings.xml:413: Error: Incorrect formatting string liquidityads_estimate_above_25; missing conversion character in '% s'? [StringFormatInvalid]
Tổng phí cao hơn 25% so với khoản thanh khoản đã yêu cầu.

@dpad85
Copy link
Member Author

dpad85 commented Oct 31, 2025

The linting error is a false positive, I've added a parameter to ignore it specifically.

SqliteChannelsDbTest.read v1 db[iosSimulatorArm64] FAILED

This is likely because the db tests are not implemented for iOS (actually the part loading the test db file), see

@dpad85 dpad85 merged commit 0e92070 into master Oct 31, 2025
@dpad85 dpad85 deleted the cleanup-tests branch October 31, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants