(ios) Bug fixes for currency names#765
Conversation
…ue market)") weren't being properly translated
…e), but provide translations for for special market names (e.g. "black market")
dpad85
left a comment
There was a problem hiding this comment.
Pushed a few fixes for the French localisation. There are some other translations that need improvement, but I could not find them in the resources file. Are they automatically translated by the OS?
Currency rename from ANG to XCG is also a rename from "Netherlands Antillean Guilder" to "Caribbean Guilder". We need this change on Android too.
The name is handled by Android using the ISO code, and it seems they have not updated yet. I'm not sure it's worth adding specific code just for this case.
There are 2 localization files. One just for the currencies (which generally don't need to be translated, since iOS can handle them), and the other general one (with all the normal strings from the app). This PR only updates the currency localizations. I was planning on making a separate PR where I update all the translations.
Same on iOS. They have ANG, but not XCG yet.
Probably not. If people are mentioning the issue to us, I'm sure they've already mentioned it to Google. |
Fixing various bugs related to currencies in iOS:
We recently renamed ANG to XCG, but when looking at the list of currencies in iOS, the new XCG wasn't sorted properly. It was sorted where it was previously. So we now sort the list of currencies by their displayCode.
Currencies with "market names" (e.g. "Argentine Peso (blue market)") weren't being properly translated. So, for example, all the currencies were properly listed in French except these currencies (which were still in English).
French translation was missing "market names". E.g. "blue market". Please double-check my translations (see specific commit for it, and scan for the green code additions)
Currency rename from ANG to XCG is also a rename from "Netherlands Antillean Guilder" to "Caribbean Guilder". We need this change on Android too.