Skip to content

(ios) Special case balance display#763

Merged
dpad85 merged 1 commit intomasterfrom
ios-zero-balance-with-incoming
Oct 28, 2025
Merged

(ios) Special case balance display#763
dpad85 merged 1 commit intomasterfrom
ios-zero-balance-with-incoming

Conversation

@robbiehanson
Copy link
Contributor

@robbiehanson robbiehanson commented Oct 27, 2025

This PR matches the "balance display" changes made to Android in PR #742:

It's unrelated to the multiple wallet change, but I've also modified the balance display in the Home screen when there is no active channels but there's funds in the swap-in and/or the final wallet. It avoids displaying a big "0 sat" balance when channels get closed, which can be scary and confusing.

Note that in the nominal case, if you have funds on LN channels, the balance display is the same as before. The on-chain balance (swap-in or final) would still be displayed below the normal balance.

Simulator Screenshot - iOS 18 2 - iPhone 16 - 2025-10-27 at 14 55 43

I've also added an explicit "Spend" button for the Final wallet in the on-chain balance dialog. From what a few users report, it was not obvious that the Final wallet section could be clicked to spend the funds.

Screenshot 2025-10-27 at 11 37 34

…ightly different display in the home screen. Matches changes in Android.
@robbiehanson robbiehanson marked this pull request as ready for review October 27, 2025 19:56
@robbiehanson robbiehanson requested a review from dpad85 October 27, 2025 19:56
///
func isZeroBalanceWithIncoming() -> Bool {

let balance = mvi.model.balance?.msat ?? 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should use BalanceManager.balance, since we want to deprecate the MVI models.

@dpad85 dpad85 merged commit c392f41 into master Oct 28, 2025
@dpad85 dpad85 deleted the ios-zero-balance-with-incoming branch October 28, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants