(ios) Description was missing for outgoing payments using Bolt 12#754
Merged
robbiehanson merged 1 commit intomasterfrom Oct 13, 2025
Merged
(ios) Description was missing for outgoing payments using Bolt 12#754robbiehanson merged 1 commit intomasterfrom
robbiehanson merged 1 commit intomasterfrom
Conversation
dpad85
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was originally overlooked because we only supported the default Bolt 12 offer. And so when testing on our own offers, there was never a description. But now offers can have a description, so the bug is more visible.
Steps to reproduce:
Side note:
If you inspect the received payment on device A, it says:
^ This is wrong. Associated PR: lightning-kmp #816