Merged
Conversation
e014784 to
318aaa0
Compare
dpad85
approved these changes
Oct 3, 2025
318aaa0 to
4ca82d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
We would wrap a kotlin flow (e.g.
val foo: StateFlow<Int>) with a custom-built Publisher.This was tedious, because we needed to build our own wrapper functions. And the type of those functions needed to match the underlying type in Kotlin. Getting it wrong resulted in ... zero compiler errors or warnings! And the Publisher simply didn't work at runtime.
After:
We use SKIE FlowInterop, with automatically provides Swift with
let foo: AsyncSequence<Int>.This means we can delete our custom Publishers. And most of our tedious wrapper functions. And we can switch to modern async/await syntax.
This also seems to be the direction that Kotlin's "swift export" is going. So adopting this syntax should help us with a future migration.
Note:
We're still NOT adopting SKIE SuspendInterop in this PR. As we discovered in #551, there are some issues with that approach that we need to fix on our side.
This PR will be updated & rebased after #731 is merged.