Conversation
There is now a primary Bitcoin unit and a primary Fiat currency that define how amounts are displayed throughout the app, just like before. However inputs now accept an amount in another fiat or bitcoin unit. It means that if the user is using Euro usually, but travels to the US, he will be able to pick the USD currency when sending a payment, or when generating an invoice. A currency converter has been added to facilitate converting amounts to other currencies. This converter is how the user can add new currencies in the unit dropdowns.
Also reorganized the Settings menus to match the iOS app.
|
I assume this commit will be merged soon, so it won't matter if I translate the strings now, right? Or are there any changes coming? |
Member
Author
|
This PR is stable and will not change too much, so you can start the translation now. Thanks! |
robbiehanson
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR matches the behaviour of the iOS app, where amount inputs can be entered in various currencies, to make it easier to use Phoenix when travelling.
There is still a primary Bitcoin and Fiat currency in the app settings, and they define how amounts are displayed throughout the app, just like before.
However inputs now accept an amount in another fiat or bitcoin unit than the primary options. It means that if the user is using Euro usually and want to keep it that way, but travels to the US, he will be able to pick the USD currency when sending a payment, or when generating an invoice.
A currency converter has been added to facilitate converting amounts to other currencies. This converter is how the user can add new currencies.
Related issue: #639
Default option
Adding another currency