Fixing mimalloc memory-limit crash#324
Merged
robbiehanson merged 1 commit intomasterfrom Dec 15, 2022
Merged
Conversation
dpad85
approved these changes
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing receiving payments when Phoenix was running in the background, and noticed that it had mysteriously stopped working in recent builds. I tracked down the issue and discovered the the notification-service-extension was crashing:
This issue is that Apple limits the amount of memory that a notification-service-extension is allowed to use. The memory is capped at 24 MB (for iOS 16).
In the Kotlin docs, they say:
The "-Xallocator=std" option seems to do the trick, as I wasn't able to reproduce the crash with that option set. In fact, the memory is significantly lowered:
I don't notice any performance degradation. In fact, fetching objects from the database actually seems faster. But I can appreciate how mimalloc theoretically increases performance. So I'd be happy to revisit this when we adopt Kotlin 1.8. Or if Apple raises the memory limits in future versions of iOS.