Merged
Conversation
And other dependencies. Based on the work made in #701. We are not using the new `kotlin.Uuid`, as it is still experimental. Co-authored-by: Dominique Padiou <5765435+dpad85@users.noreply.github.com>
The min gradle version for Java 21 is 8.5.
The `deleteDokkaOutputDir` task seemed redundant as `clean` already clears everything.
pm47
commented
Feb 11, 2025
sstone
reviewed
Feb 12, 2025
sstone
approved these changes
Feb 12, 2025
t-bast
approved these changes
Feb 12, 2025
Member
t-bast
left a comment
There was a problem hiding this comment.
LGTM, works fine on my machine
Member
Author
|
Waiting from ACK from @dpad85 before merging. |
dpad85
approved these changes
Feb 13, 2025
Member
dpad85
left a comment
There was a problem hiding this comment.
Lightning-kmp builds fine on an Intel macOS 14.6 and a M3 macOS 15.3, using Xcode 16.2 (which is the latest version). We've also tested on devices with the Phoenix kotlin-2.x branch ACINQ/phoenix#654
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And upgrade other dependencies.
Based on the work made in #701, that was reverted.
We are not using the new
kotlin.Uuid, as it is still experimental.