Add a tlv to facilitate phoenix migration#319
Merged
Conversation
When connecting to our node, phoenix-kmp attaches a special tlv to its `init` message with the `nodeId` of the legacy phoenix-eclair. Our node later sends a `warning` message indicating whether the legacy `nodeId` has any channels attached to it.
t-bast
reviewed
Feb 3, 2022
sstone
reviewed
Feb 3, 2022
src/commonTest/kotlin/fr/acinq/lightning/wire/InitTlvTestsCommon.kt
Outdated
Show resolved
Hide resolved
t-bast
previously approved these changes
Feb 3, 2022
sstone
previously approved these changes
Feb 3, 2022
dpad85
approved these changes
Feb 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When connecting to our node, phoenix-kmp attaches a special tlv to its
initmessage with thenodeIdof the legacy phoenix-eclair. Our nodelater sends a
warningmessage indicating whether the legacynodeIdhas any channels attached to it.