This repository was archived by the owner on Feb 12, 2025. It is now read-only.
OpenChannelCapacityFragment: Fix off-by-one in max capacity#210
Merged
dpad85 merged 1 commit intoACINQ:testnetfrom Sep 19, 2019
maflcko:patch-1
Merged
OpenChannelCapacityFragment: Fix off-by-one in max capacity#210dpad85 merged 1 commit intoACINQ:testnetfrom maflcko:patch-1
dpad85 merged 1 commit intoACINQ:testnetfrom
maflcko:patch-1
Conversation
Member
|
Good catch, thanks! However this does not fix #202. To know what channel capacity would exhaust our balance, we need first to estimate the fees for a multisig tx (i.e simulating a channel), and that does not work well. So the issue must be either in the method creating the fake multisig tx, or in the wallet in eclair-core. |
Member
dpad85
approved these changes
Sep 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially fixes #202
(didn't test because I couldn't figure out how to compile and run this easily without some binary blob from google)