This repository was archived by the owner on Feb 12, 2025. It is now read-only.
Merged
Conversation
old means without this tx, new means with this tx
* if this boolean is true, Lightning payments should fail if the fee exceeds 1% of the amount of the payment.
* added comments in App.java * removed occurrences of printstacktrace * handling case where wallet does not retrieve onchain address on time
This prevents an issue at startup where electrum returns a zero balance because it is too slow to fetch the relevant data from the servers, even if eclair wallet knows from its DB that the balance may not be 0. In last resort we rely on the onchain txs recorded in the Eclair Wallet payment DB. If the balance from the wallet is truly 0 and the balance from the payment DB returns a wrong non zero balance, it can only be because Eclair Wallet was not notified with the latest txs, and should be notified soon, in which case the balance from the payment DB will be corrected.
* removed early node's uri validation. Error is shown in the modal window to streamline the user experience * open channel modal should have the same look and feel than payment modal
* tx is added to DB as soon as btc onchain payment completes * added null guards in PaymentListFragment
* Pulling the balance from the front end returns an inadequate balance when the app is starting because txs are not all pulled yet. * Listening to the ElectrumWallet.Ready event gives the current balance. Also, the ready event is pushed when the wallet receives a new tx which makes it perfect for updating the balance. * When the app starts, the balance is calculated from the existing payments in the DB. This value is overriden by the real balance in the wallet as soon as the wallet is ready.
…unit * enabled preferred bitcoin unit preference * preferred unit is now stored in the `btc_unit` field in default prefs * payments amount is now formatted and displayed in the user's preferred unit
* payments list and its content is refreshed when user's preferred bitcoin unit or fiat currency is changed * exchange rate is now stored as a static value in App
* User clicks on the balance view in home to display amounts in fiat currency or in bitcoin * Change in this preferrence refreshes balance & payments list * CoinAmountView components are not clickable anymore because the unit/currency change is centralized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to Electrum; improved fees management; added user preferences
Removed Bitcoinj dependency and all associated code
Backend wallet is now Electrum, through a new version of eclair-core
Communication between Eclair Wallet and Electrum works through the
PaymentSupervisoractorMoved targetSDK to 26 (sdk 27 can not be used until the following issue is fixed:https://issuetracker.google.com/issues/68454482)
Updated design of
Open ChannelandSend Paymentmodal windowsImproved error feedback when sending a payment and opening a channel
Fees estimations are periodically fetched by eclair-core and are now displayed in the payment form
Fast fees means that the tx should be included in the next 2 blocks (20min)
Medium fees means in the next 12 blocks (2h)
Slow fees in the next 72 blocks (12h)
Amounts in home (payments and balance) can now be displayed in fiat currency. Default value is USD. Rate value is fetched from the coindesk API.
Amounts in home are displayed in the user's preferred bitcoin unit (mBTC, BTC)
Added an optional PIN when sending a payment
User can now set preferences such as the preferred bitcoin unit (mBTC, BTC), the preferred fiat currency, requiring a PIN code when sending a payment...
Prefer balance calculated from payment DB when balance from wallet is 0. This prevents an issue at startup where electrum returns a zero balance because it is too slow to fetch the relevant data from the servers, even if eclair wallet knows from its DB that the balance may not be 0. In last resort we rely on the onchain txs recorded in the Eclair Wallet payment DB.
Disabling buttons when payment is processing instead of hiding them
removed early node's uri validation. Error is shown in the modal window to streamline the user experience
Ignoring tx confidence events where conf > 10