Update Funding tx id value in GUI when funding is signed#511
Merged
pm47 merged 2 commits intoACINQ:masterfrom Mar 28, 2018
Merged
Update Funding tx id value in GUI when funding is signed#511pm47 merged 2 commits intoACINQ:masterfrom
pm47 merged 2 commits intoACINQ:masterfrom
Conversation
Currently the only time the "Funding tx id" text in GUI is updated is upon receiving the ChannelRestored event, which means that if the GUI is not restarted the value keeps showing "N/A". I have started fixing it in this PR but I'm not sure about when the value should be updated: * As soon as we have a signed funding ? * Only after the funding tx has been published ? * Only after the funding tx has been confirmed ? How about adding the status of the funding tx as well next to the id value, eg: Funding tx id: a373e728dba3b97801b17a2a8d534d63c095304768012329427bd85c786e8b1b (SIGNED|PUBLISHED/CONFIRMING|CONFIRMED)
Member
|
Thanks for the PR! Creating a new Adding the status of the funding tx (or the number of confirmations) does not bring a lot of value compared to the state of the channel. It might even confuse beginners, and for power users, it's easy to check the status of the funding tx from bitcoin core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the only time the "Funding tx id" text in GUI is updated is upon receiving the ChannelRestored event, which means that if the GUI is not restarted the value keeps showing "N/A".
I have started fixing it in this PR but I'm not sure about when the value should be updated:
How about adding the status of the funding tx as well next to the tx id value, eg, GUI would show:
Funding tx id: a373e728dba3b97801b17a2a8d534d63c095304768012329427bd85c786e8b1b (SIGNED|PUBLISHED/CONFIRMING|CONFIRMED)or maybe it would conflict with the channel "NORMAL, WAIT_FOR_..." states shown in the GUI as well (unless it's an OFFLINE state)