Close channel on BITCOIN_FUNDING_PUBLISH_FAILED#487
Merged
Conversation
Implementation should guarantee that in case of a `BITCOIN_FUNDING_PUBLISH_FAILED` event, the funding tx will *never* be published (see `commit` method in trait `EclairWallet`). With that in mind, there is no need for a `ERR_FUNDING_PUBLISH_FAILED` state, instead we can just permanently close the channel. Note that the user will receive an error "couldn't publish funding tx".
d40ad88 to
2519603
Compare
sstone
approved these changes
Mar 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation should guarantee that in case of a
BITCOIN_FUNDING_PUBLISH_FAILEDevent, the funding tx will never bepublished (see
commitmethod in traitEclairWallet).With that in mind, there is no need for a
ERR_FUNDING_PUBLISH_FAILEDstate, instead we can just permanently close the channel. Note that the
user will receive an error "couldn't publish funding tx".