Use official feature bit for option_simple_taproot#3144
Open
Use official feature bit for option_simple_taproot#3144
option_simple_taproot#3144Conversation
2 tasks
40c34ff to
4de2b89
Compare
4de2b89 to
454bf45
Compare
454bf45 to
7805b4e
Compare
7805b4e to
ea9c4ca
Compare
ea9c4ca to
48472ea
Compare
67d6160 to
76863d3
Compare
63bc51e to
fb287ea
Compare
fb287ea to
ce6eabe
Compare
sstone
reviewed
Mar 19, 2026
| if (Features.canUseFeature(localFeatures, remoteFeatures, Features.AnchorOutputsZeroFeeHtlcTx)) { | ||
| Some(AnchorOutputsZeroFeeHtlcTx(scidAlias = !announceChannel && Features.canUseFeature(localFeatures, remoteFeatures, Features.ScidAlias))) | ||
| val useScidAlias = !announceChannel && Features.canUseFeature(localFeatures, remoteFeatures, Features.ScidAlias) | ||
| if (Features.canUseFeature(localFeatures, remoteFeatures, Features.SimpleTaprootChannels)) { |
Member
There was a problem hiding this comment.
Suggested change
| if (Features.canUseFeature(localFeatures, remoteFeatures, Features.SimpleTaprootChannels)) { | |
| if (!announceChannel && Features.canUseFeature(localFeatures, remoteFeatures, Features.SimpleTaprootChannels)) { |
We currently allow opening public taproot channels, which is not yet supported as there are no specs for gossip messages for these types of channels.
Member
There was a problem hiding this comment.
Another (cleaner ?) option would be to refuse opening public taproot channels.
Member
Author
There was a problem hiding this comment.
Good catch! Done in 535ea49 and rebased to get rid of flaky tests.
Use the official feature bit and name for taproot channels and the corresponding channel types. Activate taproot channels support by default (without support for announcing such channels yet).
We only support unannounced taproot channels right now. The spec for taproot gossip isn't ready yet.
ce6eabe to
535ea49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the official feature bit and name for taproot channels and the corresponding channel types. Activate taproot channels support by default (without support for announcing such channels yet).
We have test vectors matching the spec (lightning/bolts#995) and cross-compatibility with lnd 🎉