Allow overriding max-closing-feerate with forceclose API
#3142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a6b7e5 to
93db8ab
Compare
pm47
reviewed
Sep 5, 2025
eclair-core/src/main/scala/fr/acinq/eclair/channel/fsm/Channel.scala
Outdated
Show resolved
Hide resolved
We previously used the channel capacity to adapt the feerate used for commitment transactions for mobile wallets, but now that we always use anchor outputs and package relay for mobile wallets, that isn't necessary anymore.
pm47
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a mechanism to limit the feerate used for non-urgent force-close transactions in #3097. We now provide a way to update this feerate on a per-channel basis, without restarting the eclair node, by using the
forcecloseAPI.Fixes #3108.