Conversation
We make our Bolt11 invoice parser stricter: - reject routing hint field with empty paths - reject invalid invoice expiries - reject invalid invoice `min_final_cltv_expiry_delta` We also remove a duplicated requirement around `payment_secret` and fix a few compiler warnings. Fixes #3104
thomash-acinq
previously approved these changes
Jun 25, 2025
thomash-acinq
approved these changes
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We make our Bolt11 invoice parser stricter:
min_final_cltv_expiry_deltaWe also remove a duplicated requirement around
payment_secretand fix a few compiler warnings.Fixes #3104