Merged
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #2732 +/- ##
==========================================
- Coverage 85.84% 85.81% -0.03%
==========================================
Files 216 216
Lines 18053 18053
Branches 794 803 +9
==========================================
- Hits 15498 15493 -5
- Misses 2555 2560 +5
|
pm47
reviewed
Sep 26, 2023
Member
pm47
left a comment
There was a problem hiding this comment.
I think you should set option_data_loss_protect, gossip_queries and option_static_remotekey as mandatory in reference.conf.
pm47
previously approved these changes
Sep 26, 2023
lightning/bolts#1092 makes some features compulsory and lets us assume that other nodes have support for them.
We now require at least `option_static_remotekey`.
6c4618d to
3d1e09e
Compare
pm47
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lightning/bolts#1092 makes some features compulsory and lets us assume that other nodes have support for them.