Conversation
Codecov Report
@@ Coverage Diff @@
## master #2271 +/- ##
==========================================
+ Coverage 84.31% 84.36% +0.04%
==========================================
Files 194 194
Lines 14394 14394
Branches 570 570
==========================================
+ Hits 12136 12143 +7
+ Misses 2258 2251 -7
|
t-bast
reviewed
May 16, 2022
eclair-core/src/test/scala/fr/acinq/eclair/channel/states/ChannelStateTestsHelperMethods.scala
Show resolved
Hide resolved
This reverts commit 228addf.
t-bast
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From scalatest's
ParallelTestExecutiondoc:This means that for each single test of the
channel.statespackage, we instantiate one actor system, which contains two thread pools. With default settings, that's a minimum of 2*8 threads per individual test.That's already pretty bad, and with 65cf238 (#2270) we add a factor of 3 on top of that, which makes us go past the OS limits on github CI.
(*) It's actually so bad, that tests run actually faster without parallelization!
(**) I tried to split large test files (e.g.
NormalStateSpec,ClosingStateSpec) in order to still preserve some parallelization. In theory it should have been faster and used a bit more threads than the full sequential, but I guess it depends on the run.