Skip to content

Add support for option_compression#1956

Closed
t-bast wants to merge 1 commit intomasterfrom
advertize-compression-algorithms
Closed

Add support for option_compression#1956
t-bast wants to merge 1 commit intomasterfrom
advertize-compression-algorithms

Conversation

@t-bast
Copy link
Member

@t-bast t-bast commented Sep 15, 2021 •
edited
Loading

Add support for lightning/bolts#825

This lets us specify which compression algorithms we support and use one that our peer supports as well when syncing the network graph.

@t-bast t-bast mentioned this pull request Sep 15, 2021
Closed
@t-bast t-bast force-pushed the advertize-compression-algorithms branch 2 times, most recently from aad8bba to e04b47e Compare September 15, 2021 16:37
@TheBlueMatt
Copy link

TheBlueMatt commented Sep 15, 2021 •
edited
Loading

Can you spin up a testnet3 node with this for me to test against?

@t-bast t-bast force-pushed the advertize-compression-algorithms branch from e04b47e to fa3c54f Compare September 23, 2021 07:15
@t-bast t-bast force-pushed the advertize-compression-algorithms branch 3 times, most recently from 8f0229f to 7c1f245 Compare November 30, 2021 11:04
@t-bast
Add support for option_compression
84a6a8b 
Implement lightning/bolts#825

This lets us specify which compression algorithms we support and use one
that our peer supports as well when syncing the network graph.
@t-bast t-bast force-pushed the advertize-compression-algorithms branch from 7c1f245 to 84a6a8b Compare December 1, 2021 07:44
@t-bast
Copy link
Member Author

t-bast commented Dec 1, 2021

@TheBlueMatt and I tested cross-compatibility between this branch and LDK on testnet3: everything looks good!

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #1956 (84a6a8b) into master (59b4035) will increase coverage by 0.01%.
The diff coverage is 92.77%.

@@            Coverage Diff             @@
##           master    #1956      +/-   ##
==========================================
+ Coverage   87.57%   87.59%   +0.01%     
==========================================
  Files         166      167       +1     
  Lines       12717    12750      +33     
  Branches      536      531       -5     
==========================================
+ Hits        11137    11168      +31     
- Misses       1580     1582       +2
Impacted Files Coverage Δ
...-core/src/main/scala/fr/acinq/eclair/io/Peer.scala 89.85% <ø> (ø)
...ain/scala/fr/acinq/eclair/router/FrontRouter.scala 67.37% <60.00%> (ø)
...main/scala/fr/acinq/eclair/router/Validation.scala 90.45% <70.00%> (-0.32%) ⬇️
...re/src/main/scala/fr/acinq/eclair/NodeParams.scala 91.62% <75.00%> (+0.03%) ⬆️
...core/src/main/scala/fr/acinq/eclair/Features.scala 99.09% <100.00%> (+0.02%) ⬆️
...main/scala/fr/acinq/eclair/io/PeerConnection.scala 84.23% <100.00%> (+0.06%) ⬆️
...cinq/eclair/remote/EclairInternalsSerializer.scala 97.93% <100.00%> (+0.06%) ⬆️
...src/main/scala/fr/acinq/eclair/router/Router.scala 93.78% <100.00%> (ø)
...e/src/main/scala/fr/acinq/eclair/router/Sync.scala 98.41% <100.00%> (+0.01%) ⬆️
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala 96.77% <100.00%> (+0.34%) ⬆️
... and 6 more

@t-bast
Copy link
Member Author

t-bast commented Apr 26, 2022

We decided to simply drop zlib instead.

@t-bast t-bast closed this Apr 26, 2022
@t-bast t-bast deleted the advertize-compression-algorithms branch April 26, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@t-bast @TheBlueMatt @codecov-commenter