Merged
Conversation
The `payment_secret` feature was made mandatory in #1810 and is the default in other implementations as well. We can thus force it to be available when decoding onion payloads, which simplifies downstream components (no need to handle the case where a `payment_secret` may be missing anymore).
pm47
reviewed
Jun 9, 2021
pm47
reviewed
Jun 10, 2021
eclair-core/src/main/scala/fr/acinq/eclair/payment/relay/NodeRelay.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/send/PaymentInitiator.scala
Outdated
Show resolved
Hide resolved
The `NodeRelay` actors are indexed by `payment_secret`, which ensures we will never send a mismatching `payment_secret`.
It's confusing to end with `Request` because `PaymentRequest` usually refers to Bolt 11 invoices. We now explicitly namespace these requests to distinguish between the PaymentInitiator and the PaymentLifecycle ones.
pm47
approved these changes
Jun 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
payment_secretfeature was made mandatory in #1810 and is the default in other implementations as well. We can thus force it to be available when decoding onion payloads, which simplifies downstream components (no need to handle the case where apayment_secretmay be missing anymore).I kept it optional in
PaymentRequest, otherwise all the spec test vectors would be considered invalid. We may want to update the spec test vectors once all implementations have turned on mandatory support for payment secrets and then make it a non-optional field inPaymentRequest.