Merged
Conversation
Addresses in node announcement should be sorted. We accept node announcements that don't do this, but we should do it for our own announcements. See lightning/bolts#842
pm47
approved these changes
Feb 17, 2021
Comment on lines
+75
to
+80
| val sortedAddresses = nodeAddresses.map { | ||
| case address@(_: IPv4) => (1, address) | ||
| case address@(_: IPv6) => (2, address) | ||
| case address@(_: Tor2) => (3, address) | ||
| case address@(_: Tor3) => (4, address) | ||
| }.sortBy(_._1).map(_._2) |
Member
There was a problem hiding this comment.
We could have defined an Ordering[NodeAddress], but that would probably be over engineering.
Member
Author
There was a problem hiding this comment.
I toyed with it 😃 but decided that it was indeed a bit over-engineered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses in node announcement should be sorted.
We accept node announcements that don't do this, but we should do it for our own announcements.
See lightning/bolts#842