Skip to content

Typed cltv expiry#1104

Merged
t-bast merged 5 commits intomasterfrom
typed-cltv
Aug 26, 2019
Merged

Typed cltv expiry#1104
t-bast merged 5 commits intomasterfrom
typed-cltv

Conversation

@t-bast
Copy link
Member

@t-bast t-bast commented Aug 22, 2019

When implementing payment changes (MPP and Trampoline) I found it very confusing that cltv expiry wasn't typed (and that expiry variables were half of the time incorrectly named, often not mentioning that it was a delta).

This change makes it simpler to reason about expiries and let the compiler help us when we're messing things up between expiry delta and absolute expiry.

Apologies for the long and tedious review since it touches most files :D

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants