Store failure messages for outgoing payments#1074
Closed
rorp wants to merge 6 commits intoACINQ:masterfrom
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1074 +/- ##
==========================================
- Coverage 82.7% 82.62% -0.09%
==========================================
Files 101 101
Lines 7621 7659 +38
Branches 293 302 +9
==========================================
+ Hits 6303 6328 +25
- Misses 1318 1331 +13
|
araspitzu
reviewed
Jul 15, 2019
Contributor
araspitzu
left a comment
There was a problem hiding this comment.
The concept is ACK, however storing remotely generated strings in the database represents a concern. Even though it's technically safe thanks to preparedStatement we need to be extra careful when altering the payment db since it contains our preimages.
eclair-core/src/main/scala/fr/acinq/eclair/db/sqlite/SqlitePaymentsDb.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/db/sqlite/SqlitePaymentsDb.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/db/sqlite/SqlitePaymentsDb.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/PaymentLifecycle.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/PaymentLifecycle.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/payment/Relayer.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/test/scala/fr/acinq/eclair/db/SqlitePaymentsDbSpec.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
We can create a separate DB for remotely generated strings and/or use something like |
Member
|
This change has been included in #1130 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there's no way to get payment failures using
getsentinfoRPC. This PR addresses that.