Refactor and simplify how private/public keys are tweaked for taproot spends#169
Closed
Refactor and simplify how private/public keys are tweaked for taproot spends#169
Conversation
… spends - We should not expose a Script.pay2tr() methods that sends to a raw untweaked key. It's confusing and users should never need it anyway. - SchnorrTweak.NoTweak was not needed, it is simpler to just use an optional tweak when signing with the private key
c7ded30 to
d817d31
Compare
t-bast
reviewed
Dec 15, 2025
Member
t-bast
left a comment
There was a problem hiding this comment.
Good idea, the empty p2tr() function was indeed a frequent source of bugs! I only have one comment about the default constructor for a TaprootTweak, which reintroduces the same kind of footgun (which you only use for convenience inside this repository, which isn't worth the risk of footgun).
Users now have to explicitly create a KeyPath or ScriptPath tweak.
t-bast
reviewed
Dec 15, 2025
Member
t-bast
left a comment
There was a problem hiding this comment.
LGTM! As pointed out in ACINQ/secp256k1-kmp#136, I think it's worth preparing draft PRs all the way up to eclair and lightning-kmp to ensure that everything works before going through a chain of releases?
Member
Author
|
Replaced by #170 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script.pay2tr()methods that sends to a raw untweaked key. It's confusing and users should never need it anyway.SchnorrTweak.NoTweakwas not needed, it is simpler to just use an optional tweak when signing with the private key