Add explicit removal notice + instructions for --prompt=pass#1190
Merged
mtibben merged 2 commits into99designs:masterfrom Mar 17, 2023
Merged
Conversation
It's a bit verbose / copy-pasta as I couldn't figure out a good way to pre-validate EnumVars before their own option validation kicks in.
tavisrudd
commented
Mar 17, 2023
| return nil | ||
| } | ||
| } | ||
| return fmt.Errorf("--prompt value must be one of %s, got '%s'", strings.Join(promptsAvailable, ","), a.promptDriver) |
Contributor
Author
There was a problem hiding this comment.
The original message says "enum value must" but I took the liberty of making it more explicit which flag this is for.
Contributor
Author
|
Prior behaviour |
Member
|
Thanks for the contribution @tavisrudd ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to the discussion in #1185.
It's a bit verbose / copy-pasta as I couldn't figure out a good way to pre-validate EnumVars before their own option validation kicks in.
Also, I'm a golang newb so I apologize for any stupid mistakes I need to clean up.