Preference stored credentials over other credential sources#1183
Merged
Preference stored credentials over other credential sources#1183
Conversation
This was referenced Mar 9, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @dgholz in #1181 (comment), aws-vault should prefer stored credentials over other credential sources. This would mean that if you have a profile with both stored credentials and
credential_processset, aws-vault uses the stored credentials instead of executing thecredential_process.Given that stored credentials are preferenced over other config, the config validation is not necessarily accurate. It also isn't all that useful, as logging provides feedback about which credential source has been selected, and so being permissive about config is probably a better route anyway. For that reason, the strict config validation has been removed.
Fixes #1176, #1180, #1181