qt: Avoid duplicate mouse capture requests#7156
Merged
OBattler merged 1 commit intoMay 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repeated fullscreen toggles on Qt6/Wayland can re-enter mouse capture while the pointer is already locked, which ends in the Wayland protocol error about the surface already being constrained.
This crashes 86Box so badly on my machine that 86Box.cfg is overwritten with defaults for some reason.
It started after 7ea6e9c began capturing the mouse on every fullscreen entry.
The Qt handler behind
setMouseCapturewas not idempotent, so duplicate requests still ran the backend capture path.Fix it by treating mouse capture as a real state transition and ignoring requests that do not change the stored capture state.
Checklist