Skip to content

Mouse capture improvements#7145

Merged
OBattler merged 3 commits into
86Box:masterfrom
lemondrops:fullscreen-mouse-capture
May 17, 2026
Merged

Mouse capture improvements#7145
OBattler merged 3 commits into
86Box:masterfrom
lemondrops:fullscreen-mouse-capture

Conversation

@lemondrops

@lemondrops lemondrops commented May 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Always capture mouse when entering full-screen mode;
  • Fix a bug where the cursor reappears if the machine is hard reset while mouse capture is on;
  • Remember the mouse capture state when a modal window is opened, and restore it once the window is closed.

Checklist

References

N/A

@usergithub64

Copy link
Copy Markdown
Contributor

In fullscreen mode with a hard reset, mouse auto-capture does not occur. Can this be fixed? In my PR it was already done that during soft reset and hard reset in windowed/fullscreen mode, with the "Auto-capture mouse" checkbox enabled, auto-capture of the mouse also occurred.

@lemondrops

Copy link
Copy Markdown
Contributor Author

In fullscreen mode with a hard reset, mouse auto-capture does not occur.

Have you tested this with this PR specifically?

@lemondrops

Copy link
Copy Markdown
Contributor Author

I've managed to reproduce the hard reset bug - it also happens in windowed mode.

@usergithub64

Copy link
Copy Markdown
Contributor

In fullscreen mode with a hard reset, mouse auto-capture does not occur.

Have you tested this with this PR specifically?

yes

@lemondrops

Copy link
Copy Markdown
Contributor Author

@usergithub64 Try now, this should handle both the bug with the cursor reappearing after a hard reset (while the emulator still thinks that capture is enabled) and remembering/restoring the capture state when a modal window (such as a hard reset confirmation dialog) is open/closed.

@lemondrops lemondrops changed the title Always capture mouse when entering fullscreen mode Mouse capture improvements May 17, 2026
@OBattler OBattler merged commit 0ef5006 into 86Box:master May 17, 2026
45 checks passed
@lemondrops lemondrops deleted the fullscreen-mouse-capture branch May 17, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants