Some small fixes for codegen-new#7080
Merged
Merged
Conversation
The load slow-path shim is entered via CALL from the JIT block body (RSP % 16 == 0 at that point, so RSP % 16 == 8 inside the shim). After saving RAX and RDX with two PUSHes RSP % 16 is still 8, which violates the SysV AMD64 ABI 16-byte alignment requirement before a CALL. The store routine already carried the compensating SUB RSP,8 / ADD RSP,8 pair; apply the same fix to the load routine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the following issues I have encountered while using the codegen-new:
I ran into the linker optimization issues (function inlined, stale pointer) when compiling with lto=auto on GCC.
GCC 15.2.0 also aligns differently, causing stack misalignment bug in JIT load, crashing the game "Incoming" on startup.
Checklist