sound: derive WTBUFLEN from WT_FREQ#6951
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix
WTBUFLENso the wavetable buffer length is derived fromWT_FREQinstead ofMUSIC_FREQ.the old code mixed two different subsystems:
that meant the wavetable path declared a 44.1 khz rate, but sized its buffer as if it were running at 49.716 khz. this changes the batching threshold from
1104samples to980samples and makes the wavetable path internally inconsistent.this pull request changes it to:
Checklist
References
/src/include/86box/sound.h