Skip to content

Fixes and improvements to the settings overhaul and tape drives#6893

Merged
OBattler merged 17 commits into
86Box:masterfrom
lemondrops:ui-post-overhaul
Mar 9, 2026
Merged

Fixes and improvements to the settings overhaul and tape drives#6893
OBattler merged 17 commits into
86Box:masterfrom
lemondrops:ui-post-overhaul

Conversation

@lemondrops

@lemondrops lemondrops commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Update the settings dialog page headers dynamically instead of hardcoding them in the .ui files
  • Fix various spacing issues between controls in the settings dialog
  • Disable the interpreter override checkbox in non-286/386 CPUs
  • Fix the HDD audio combobox being too small
  • Select the first item in the hard disk list (if present) when first opening the dialog, for consistency with floppy/CD-ROM/removables
  • Remove now-redundant groupboxes
  • Fix a few broken translations (more fixed in Update translations #6894)
  • Better handle the absence of FDD and HDD audio profiles
  • Move non-generic MFM/RLL HDD profiles below all generic ones
  • Add tape drives to the manager's detail pane
  • Generalize the tape drive bus in the media menu in preparation for ATAPI tape drives
  • Explicitly set Qt application name on startup instead of deriving it from the executable name, fixes global config being reset if the executable is renamed
  • Fix legacy SDL UI build failure

Checklist

  • Closes #xxx
  • I have tested my changes locally and validated that the functionality works as intended
  • I have discussed this with core contributors already
  • This pull request requires changes to the ROM set
  • This pull request requires changes to the asset set

References

N/A

@lemondrops lemondrops mentioned this pull request Mar 9, 2026
5 tasks
@OBattler OBattler merged commit c6e5220 into 86Box:master Mar 9, 2026
43 of 44 checks passed
Comment thread src/unix/unix.c
|| fn[strlen(fn) - 1] == '"')
fn[strlen(fn) - 1] = '\0';
printf("Inserting disk into tape drive %c: %s\n", id + 'A', fn);
tape_mount(id, fn, wp);

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This argument to a file access function is derived from user input (string read by __getdelim) and then passed to tape_mount(fn), which calls tape_load(fn), which calls plat_fopen(path), which calls fopen(__filename).
This argument to a file access function is derived from user input (string read by __getdelim) and then passed to tape_mount(fn), which calls tape_load(fn), which calls plat_fopen(path), which calls fopen(__filename).
@lemondrops lemondrops deleted the ui-post-overhaul branch March 9, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants