Fix macOS toolbar label disappearing on mouse capture#6829
Merged
Conversation
BSD swprintf fails (returns -1) when the format string or a %ls argument contains non-ASCII wide characters under the C locale. On macOS, QKeySequence::NativeText produces Unicode key symbols (⌘ U+2318, ⌫ U+232B) in the release-mouse string, causing swprintf to zero out mouse_msg[1]. This made the title bar label collapse to empty during mouse capture. Avoid swprintf for non-ASCII content on macOS: store message suffixes with wcsncpy and build the title string via wcsncat at the update site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
swprintfreturns -1 when the format string or%lsargument contains non-ASCII wide characters under the C localeQKeySequence::NativeTextproduces Unicode key symbols (⌘ U+2318, ⌫ U+232B) in the release-mouse string, causingswprintfto zero outmouse_msg[1]and collapse the title bar label to empty during mouse captureswprintffor non-ASCII content on macOS — store message suffixes withwcsncpyand build the title string viawcsncatat the update siteTest plan