net_switch: build secret_hash header as a separate component#6795
Merged
Conversation
The prior code did a memmove over the packet data, and in cases where a packet is completely full (large transfers under an MTU 1500, for instance), it would corrupt the data packet and nothing got transferred. In its place, teach the code to build up the secret_hash header as a separate component and send a larger packet (by 32 bytes). The original packet remains intact and will get received by the intended target this way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The prior code did a memmove over the packet data, and in cases where a packet is completely full (large transfers under an MTU 1500, for instance), it would corrupt the data packet and nothing got transferred.
In its place, teach the code to build up the secret_hash header as a separate component and send a larger packet (by 32 bytes). The original packet remains intact and will get received by the intended target this way.
Checklist