Skip to content

Qt: Fix media file picker location persistence#6789

Merged
OBattler merged 1 commit into
86Box:masterfrom
asemarafa:fix-file-picker
Feb 8, 2026
Merged

Qt: Fix media file picker location persistence#6789
OBattler merged 1 commit into
86Box:masterfrom
asemarafa:fix-file-picker

Conversation

@asemarafa

Copy link
Copy Markdown
Contributor

Summary
This PR fixes an issue where media file pickers (Floppy, CD, etc.) would reset to the 86Box home folder every time
they were opened. This was particularly annoying during disk swaps for multi-disk installations, as it forced users to
navigate back to their images directory repeatedly.

Changes:

  • Updated MediaMenu::getMediaOpenDirectory() to return the home folder only on the first invocation. Subsequent calls
    return an empty string, allowing the native file dialog to persist its last visited location.
  • Updated MediaMenu::cdromMount to use getMediaOpenDirectory() for consistency across all media pickers.

Checklist

  • Closes #xxx
  • I have tested my changes locally and validated that the functionality works as intended
  • I have discussed this with core contributors already
  • This pull request requires changes to the ROM set
  • This pull request requires changes to the asset set

References
N/A

@OBattler OBattler merged commit 03b3f64 into 86Box:master Feb 8, 2026
44 checks passed
@OBattler

OBattler commented Feb 8, 2026

Copy link
Copy Markdown
Member

Finally! This has been annoying me for ages.

@asemarafa asemarafa deleted the fix-file-picker branch February 8, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants