CPU: Restrict allowed opcodes in INC/DEC Grp4 #6561
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue in the
FEopcode (referred in Intel docs as "INC/DEC Grp 4") where any ModR/M Opcode bits other than 000 act asDEC r/m8. All other values than 000 or 001 are invalid and should throw#UDon processors that support that.This also shows on actual hardware: similarly-configured Cyrix 5x86 and 486DX systems throw a
#UDexception, but not in 86Box. (Thanks to @goshhhy for testing this!)Checklist
References
Intel® 64 and IA-32 Architectures Software Developer's Manual Combined Volumes 2A, 2B, 2C, and 2D, Appendix A.4.2.
Tested using the boot sector program here: https://datagirl.xyz/pub/grp4test.bin (source code: https://datagirl.xyz/pub/grp4test.asm)