Skip to content

Manager: Toolbar and other improvements #6544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OBattler merged 18 commits into from
Dec 8, 2025
Merged

Manager: Toolbar and other improvements #6544

OBattler merged 18 commits into from
Dec 8, 2025

Conversation

@lemondrops
Copy link
Contributor

@lemondrops lemondrops commented Dec 8, 2025

Summary

  • Add a toolbar to the manager (or rather, fix and unhide it)
  • Move the search bar to the top of the machine list; fix its placeholder text not being updated on language change
  • Remove searching by machine configuration; this was an experiment that wasn't supposed to be left enabled
  • Make pressing Enter when the machine list is focused start the selected VM
  • Refresh only the configuration and screenshots instead of the entire details pane when a configuration change signal is received; also do it on VM stop
  • Fix VM crash dialogs appearing more than once under certain circumstances
  • In the VM crash dialog, the exit code's hex readout is now always shown
  • Increase the machine status text in the machine list to increase legibility at 100% scaling with certain languages

Drive-by: Show icons for in menus for items that have them due to being present in the toolbar

Checklist

  • Closes #xxx
  • I have tested my changes locally and validated that the functionality works as intended
  • I have discussed this with core contributors already
  • This pull request requires changes to the ROM set
  • This pull request requires changes to the asset set

References

N/A

@lemondrops
Manager: Allow starting the currently selected VM by pressing Enter
75499ad
@lemondrops
Manager: Fix the search field placeholder not being updated on langua…
c9fb23c 
…ge change
@lemondrops
Manager: Disconnect previous signal connections from the process obje…
50023a6 
…ct before starting the VM

Fixes crash dialog appearing more than one time under certain circumstances
@lemondrops
Manager: Fix exit code's hex readout only showing if a VM is invoked …
457b5c3 
…in settings-only mode
@lemondrops
Manager: Increase the machine status text size in the list view
11da493 
Should help with readability in CJK languages with 100% scale
@lemondrops
Manager: Simplify the connection chain for the configuration refresh …
fd3a79e 
…signals

This allows refreshing the config without redrawing the entire details pane
Also refresh the config and screenshots on VM termination
@lemondrops
Manager: Don't add machine configuration fields to the search index
d092680
@lemondrops
Manager: Initial preparation for re-enabling the toolbar:
1dd681f 
* Increase button size and display text under icons
* Remove the duplicate search bar
* Move the existing search bar to the top of the machine list
@lemondrops
Manager toolbar: Re-enable the Ctrl+Alt+Del button
85b26b4
@lemondrops
Manager: Remove an unused function
517a9f2
@lemondrops
Manager toolbar: Improve the logic for updating the toolbar button st…
b5c6ebd 
…ate on VM selection change
@lemondrops
Manager toolbar: Cache run/pause icons
c325ea0
@lemondrops
Manager: Unhide the toolbar
26f4916
@lemondrops
Manager: Sync toolbar button state with selected VM's state
d2379f1
@lemondrops
Manager: Make the toolbar hideable
f3168b4
@lemondrops
Manager: Use the new icon for the "New machine" button
d5b06c5
@lemondrops
Qt: Remove the shortcutVisibleInContextMenu property from menu items
2e9dec8
@lemondrops
Qt: Show icons in menu for actions that have them
74eb213
@OBattler OBattler merged commit e47dc48 into 86Box:master Dec 8, 2025
45 checks passed
@lemondrops lemondrops deleted the manager-toolbar branch December 8, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lemondrops @OBattler