PCjr: Fix inverted horizontal screen movement #6434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The IBM PCjr allows for horizontal screen movement using the
Ctrl + Alt + Left/Right Arrow Keysshortcut.Currently, it's inverted:
Ctrl + Alt + Leftmoves the screen right (should move left)Ctrl + Alt + Rightmoves the screen left (should move right)The section “Centering Information on the Screen” in the IBM PCjr Guide To Operations confirms the intended behavior.
Also, increasing the value in the R2 register of the CRTC should shift the display left, and decreasing it should shift it right. If you look at the register values while shifting the screen, you'll see that the current calculation does the opposite.
This PR fixes the issue.
Checklist
References
Provide links to datasheets or other documentation that helped you implement this pull request.