use SO_REUSEADDR on gdb stub socket #6101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
You should ifdef out the part for Windows platforms; this should be fine otherwise. |
Contributor
Author
windows has SO_REUSEADDR I think the difference is in the function signature (it needs const char * instead) |
ac57ae6 to
5673f4a
Compare
5673f4a to
b6b4bb5
Compare
Contributor
Author
|
I've updated the code path for windows (also added SO_EXCLUSIVEADDRUSE), but I'm unable to trigger the action for msys2 in my fork |
Member
|
I approved the actions on your pull request now, so the one for Msys2 is going to be performed here now. Waiting for them all to finish now. |
Member
|
It passed all checks, therefore, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm trying to debug a real bios with gdb stub, I restart often and sometime 86Box doesn't wait for debugger.
Looks like the problem is missing SO_REUSEADDR on the socket.
Could you please check on other platform (it's only tested on Linux)