Restore debug register emulation for 486+ CPUs behind a compile-time option #4484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But put it behind a compile-time option due to performance hits Also add the DE flag to CPUID on supported CPUs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extends (or rather, brings back previously removed code for) full debug register emulation to 486 and later CPUs, including I/O breakpoints for most P5 and P6-class ones. Due to a major performance decrease even during regular usage, especially on lower-end host PCs (the reason it is normally limited to 386 CPUs) with it present, it must now be enabled during compile time with the
DEBUGREGS486option.Checklist
References
N/A