Add support for pcjs json floppy images #4467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for pcjs json floppies. This PR also adds cJSON to 86Box in order to properly support the required json parsing. cJSON is a lightweight json parser for C and comes in the form of a single source / single header file combo.
Specifically, this implements v2 of the pcjs image spec. All disk images are treated as read-only.
More information here: https://www.pcjs.org/tools/diskimage/
pcjs v2 spec info: https://github.com/jeffpar/pcjs/blob/master/machines/pcx86/modules/v2/disk.js
This supplants the existing pcjs json floppy support (
fdd_json.candfdd_json.h) which was written to the pcjs v1 spec. Those files can be removed once this is merged.Checklist
References
https://www.pcjs.org/tools/diskimage/
https://github.com/DaveGamble/cJSON