Modify the PCAP filter to allow multicast packets #4289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also fix AppleTalk if someone is using NT Services For Macintosh or PCMacLAN in a VM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies the PCAP filter accordingly:
broadcastkeyword is used instead offf:ff:ff:ff:ff:ffThe biggest effect is fixing NetBEUI / NetBIOS which was not working before: NetBEUI uses a multicast address (
03:00:00:00:00:01) instead of a standard ethernet broadcast which was not passing the PCAP filter.Anything that uses NetBEUI / NetBIOS should now work with PCAP, including LAN Manager. Any other L3 that uses multicast should also now work.
Screenshot of win98 with no TCP/IP installed, using only NetBEUI to communicate with another win98 host configured the same:
Checklist
References
N/A