Skip to content

Conversation

@lemondrops
Copy link
Contributor

Summary

  • Cleanup of leftovers of the Win32 UI and legacy Makefile:
    • Hardcode the Qt UI CMake option to ON on Windows;
    • Remove leftover header files, trim win.h to only contain manager protocol stuff;
    • Clean up the plat_ and ui_ internal API: functions no longer defined or used in any of the remaining UIs have been removed; non-multi-monitor-aware plat_resize() has been removed, with plat_resize_monitor() being renamed to plat_resize();
    • Overhaul plat_get_string() to take constants with human-readable names instead of Win32 string table IDs; ui_msgbox() and ui_msgbox_header() no longer accept said IDs either, the pointer returned by plat_get_string() must be passed explicitly.
  • Translation cleanup:
    • Remove many unused strings;
    • The Windows font override is now hardcoded to specific languages that need such an override instead of being defined by the translation file; the original way only made sense in the context of the Win32 UI anyway;
    • Some strings in the translation files have been updated to no longer require search-and-replace to insert platform-dependent information or to fit the Qt UI;
    • Restore the pcap error messages talking about (wi)Npcap on Windows instead of libpcap;
    • The translation files now have headers indicating their source and target languages;
    • the English translation files have been purged from redundant localizations.
  • Other cleanup:
    • Remove the unused and unfinished Qt SDL renderer;
    • Remove the unused and unmaintained pcap_if utility;
    • Don't accept no longer used disk bus type options in the config file.

Checklist

  • Closes #xxx
  • I have discussed this with core contributors already
  • This pull request requires changes to the ROM set

References

N/A

Remove functions no longer defined or used on any plat/UI
Remove the old non-multi-monitor-aware plat_resize() and rename
plat_resize_monitor() to plat_resize()
Now takes constants with human-readable names instead of
Win32 string table IDs, language.h is no longer needed

ui_msgbox*() no longer accepts string IDs as arguments directly,
plat_get_string() must be explicitly called to retrieve the string
Determine which font to use with a dedicated function instead
Use Qt `.arg()` instead of substring replacement;
Fully remove remnants of SDL renderers from translations;
Restore platform-dependent pcap library name in the pcap
error message, but use Npcap on Windows instead
@OBattler OBattler merged commit de1406c into 86Box:version/4.2 Mar 20, 2024
@lemondrops lemondrops changed the title Cleanup of legacy and unused things [v4.2] Cleanup of legacy and unused things Mar 20, 2024
@lemondrops lemondrops deleted the cleanup branch March 20, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants