Skip to content

Qt: Application icon fixes #3915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OBattler merged 2 commits into from
Dec 20, 2023
Merged

Qt: Application icon fixes #3915

OBattler merged 2 commits into from
Dec 20, 2023

Conversation

@lemondrops
Copy link
Contributor

@lemondrops lemondrops commented Dec 20, 2023

Summary

  • Set the window icon for the entire application, instead of just the main window; fixes dialog windows having a generic icon when the main window isn't initialized (like the standalone Settings dialog)
  • Set the .desktop file name on *nix; may possibly fix the generic icon showing up instead of 86Box's icon on Wayland

Checklist

  • Closes #xxx
  • I have discussed this with core contributors already
  • This pull request requires changes to the ROM set

References

https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Application_Icon

@OBattler OBattler merged commit 2ccc46d into 86Box:master Dec 20, 2023
@lemondrops lemondrops deleted the qt_icons branch December 20, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lemondrops @OBattler