Disable blink in 8bpp modes on MGA; Re-instate main 8bpp hires renderer #3893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't actually know if 8bpp blink is a thing on a Matrox Millennium, but the video BIOS seems to act like it's not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should fix the blinking in 8bpp modes on the Matrix Millennium.
What I've been using to test this:
In a non-CJK MS-DOS 6.2x, run
debug, then:Now you're in mode 13h, run
qbasicand then exit it. (esc, alt, f, x - all separate keys)The background should be black. If it's reddish-brown, then you've ended up in the weird thing that is 8bpp blink mode, which is supported by some VGA clones but not all. The Matrox Millennium card sets the blink bit, so what this PR does is it tells the renderer to ignore the blink bit when bpp > 4 on a Matrox card.
Checklist
References
None