fix flags for serial passthrough on unix #3691
Conversation
|
Thank you for the PR. Did you notice the serial port being stuck in random configurations while serial passthrough was in use, or after exiting 86Box? |
|
In use. The bug this fixes made the serial passthrough essentially unusable. |
|
Seems to be related to #3224 |
|
Alright. I was able to previously (without the fix) access a serial console in a linux guest, macOS host, using |
|
Note that this is relevant for passthrough to a real physical host serial port (tested on macOS host with FTDI serial converter). It does not matter for ptys as the there is no hardware UART to configure. Without the fix sending U (0x55) from the VM leads to this: ie. 5 databits, not 8 as in the configuration file. The reason for this behavior is that the expression on line 168 clears the configured number of databits. |
Summary
The logic for clearing bits in termios.c_flag was reversed. That caused clearing of all the other flags than which were intended to be cleared, which in turn caused the host serial port to be stuck at random and unusable configuration (5 data bits on macOS).
Checklist