Fix GDB stub builds due to undeclared symbol #3655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a build issue that occurred when compiling with GDBSTUB support (-DGDBSTUB=ON). The issue was introduced in commit 565421a, which commented out the GDB_REG_FS_BASE and GDB_REG_GS_BASE registers, but did not remove the code snippets that referenced them in gdbstub_client_write_reg(). This commit comments out those code snippets as well. Additionally, this commit removes the fs_base and gs_base registers from the XML file, to ensure the correct numbering of the registers for the GDB.
Member
|
I recommend making another PR witth those patches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a build issue that occurred while building with GDB stub support (
-DGDBSTUB=ON) enabled, as can be seen in:The issue was introduced in commit 565421a, which commented out the
GDB_REG_FS_BASEandGDB_REG_GS_BASEregisters, but did not remove the code snippets that referenced them ingdbstub_client_write_reg(). This PR comments out those code snippets as well.Additionally, I've removed the
fs_baseandgs_baseregisters from the XML file, to ensure the correct numbering of the registers for the GDB.Note: I have three other small patches for
gdbstub.c, should I submit them in separate PRs or is one enough?Checklist
References