Skip to content

Conversation

@luennix
Copy link
Contributor

@luennix luennix commented Aug 18, 2023

Summary

Add the Micronics Thunderbolt motherboard with 430TX chipset and PhoenixBIOS 4.0 Release 6.0 (without the onboard Yamaha YMF701 audio chip).

Checklist

References

https://theretroweb.com/motherboards/s/micronics-thunderbolt-09-00293-xx

OBattler and others added 16 commits August 17, 2023 02:46
Eliminate the 2401 display error on MCA machines using the Cirrus cards.
…on faults on certain accessed by the old recompilers.
…uld not have been, fixes the music on Princess Maker 2, fixes 86Box#3233.
…e way file names are handled for all media, they are now all saved as relative.
{
serial_t *dev = (serial_t *) priv;

dev->lsr = (dev->lsr & 0xfe) | !fifo_get_empty(dev->rcvr_fifo);

Check failure

Code scanning / CodeQL

Incorrect 'not' operator usage

Usage of a logical not (!) expression as a bitwise operator.
fatal("load_floppy_and_cdrom_drives(): strlen(p) > 511 "
"(fdd_image_history[%i][%i])\n", c, i);
else
snprintf(fdd_image_history[c][i], 511, "%s", p);

Check failure

Code scanning / CodeQL

Badly bounded write

This 'call to snprintf' operation is limited to 511 bytes but the destination is only 257 bytes.
else
snprintf(fdd_image_history[c][i], 511, "%s", p);
} else
snprintf(fdd_image_history[c][i], 511, "%s%$s%s", usr_path,

Check failure

Code scanning / CodeQL

Badly bounded write

This 'call to snprintf' operation is limited to 511 bytes but the destination is only 257 bytes.
@jriwanek
Copy link
Member

This should be based against 4.1, not master.

@OBattler OBattler merged commit 6a97893 into 86Box:version/4.1 Aug 19, 2023
@luennix luennix deleted the thunderbolt branch August 19, 2023 05:10
@luennix
Copy link
Contributor Author

luennix commented Aug 19, 2023

This should be based against 4.1, not master.

my bad, I will base on 4.1 next time and then issue the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants